[Webkit-unassigned] [Bug 45443] [GTK] Support for viewport meta tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45443





--- Comment #46 from Joone Hur <joone at kldp.org>  2010-10-27 20:47:00 PST ---
(In reply to comment #42)
> (From update of attachment 71716 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71716&action=review
> Shouldn't webkit_web_view_init_viewport_attributes call webkit_viewport_attributes_compute_internal itself? Is there a situation where you'd want to call webkit_web_view_init_viewport_attributes without immediately calling webkit_viewport_attributes_compute_internal? Is it possible to move webkit_viewport_attributes_compute_internal into the body of webkit_viewport_attribute_recompute and have webkit_web_view_init_viewport_attributes call webkit_viewport_attribute_recompute?

It is possible to move webkit_viewport_attributes_compute_internal into the body of webkit_viewport_attribute_recompute if not consider DRT. In addition, I am going to remove webkit_web_view_init_viewport_attributes function because it is only used for DRT. Instead, I'll add a similar function in DumpRenderTreeSupportGtk as you told.

Sharing the same functionalities between WebKit and DRT seems very hard in this case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.