[Webkit-unassigned] [Bug 45982] Web Inspector: FileSystem integration

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45982





--- Comment #26 from Michael Nordman <michaeln at google.com>  2010-10-27 18:40:19 PST ---
(From update of attachment 71832)
View in context: https://bugs.webkit.org/attachment.cgi?id=71832&action=review

> WebCore/inspector/CodeGeneratorInspector.pm:49
> +    "domainAccessor" => "m_inspectorController->fileSystemAgent()",

I'm just curious about what the "domainAccessor" annotation here means?

> WebCore/inspector/InspectorFileSystemAgent.cpp:134
> +            LocalFileSystem::localFileSystem().requestFileSystem(document, asyncFileSystemType, 0, new InspectorFileSystemAgentCallbacks(this, asyncFileSystemType, origin));

We're bailing out of the 'tree' iteration early, does 'tree' need to be reset for the next consumer? How does that work?

Oh... i see FrameTree is actually a node in the tree, so this iteration isn't quite right. You have to access the tree(node) associated with the current 'frame' and traverse to the next thru it. If there's a convention for performing this iteration, its probably a good idea to follow that convention here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.