[Webkit-unassigned] [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48094





--- Comment #11 from Aaron Colwell <acolwell at chromium.org>  2010-10-27 16:28:42 PST ---
(In reply to comment #9)
> (From update of attachment 71930 [details])
> This looks like a pixel test, so it needs expectations (video-canvas-alpha-expected.txt, .checksum, and .png).

I've submitted a new patch that contains the expectation files.

> 
> Are you sure about that rounding/clipping logic?  Is it needed?  Do we do this anywhere else?

The clipping logic is needed especially since no clipping is enforced in the setAlpha() on the platform context. This code is modeled after the following pieces of code that I ran into when trying to see how <img>s are drawn to the canvas under similar circumstances.

http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/skia/ImageSkia.cpp#L239
http://trac.webkit.org/browser/trunk/WebCore/platform/graphics/skia/PlatformContextSkia.cpp#L196

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.