[Webkit-unassigned] [Bug 6751] For unnamed frames, window.name returns a generated name

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=6751





--- Comment #7 from Daniel Bates <dbates at webkit.org>  2010-10-27 15:14:52 PST ---
(In reply to comment #6)
> (From update of attachment 71666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71666&action=review
> 
> > WebCore/page/FrameTree.cpp:45
> > +    m_name = name;
> >      if (!parent()) {
> > -        m_name = name;
> > +        m_uniqueName = name;
> 
> Is m_uniqueName guaranteed to be unique?  If I explicitly set the name of two frames, can I cause a collision?

Yes, m_uniqueName is guaranteed to be unique by the if-condition in FrameTree::uniqueName() <http://trac.webkit.org/browser/trunk/WebCore/page/FrameTree.cpp?rev=60287#L104> and FrameTree::child(const AtomicString& name) <http://trac.webkit.org/browser/trunk/WebCore/page/FrameTree.cpp?rev=60287#L159>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.