[Webkit-unassigned] [Bug 48326] [NRWT] Don't use image hash when it's no need in single test mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48326


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71994|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2010-10-27 08:04:34 PST ---
(From update of attachment 71994)
View in context: https://bugs.webkit.org/attachment.cgi?id=71994&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:161
> +    image_hash = test_info.image_hash()
> +    if (test_args.new_baseline or test_args.reset_results or
> +        not options.pixel_tests):
> +        image_hash = None
> +    return image_hash

Standard webkit style for something like this is to use early returns. Also, there's no 80 column limit in WebKit code. You're supposed to go with what looks most readable. It's certainly arguable in this case.

if (test_args.new_baseline or test_args.reset_results or not options.pixel_tests):
    return None
return test_info.image_hash()

Please fix the early return issue. I don't feel strongly about the wrapping.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.