[Webkit-unassigned] [Bug 47903] [EFL] Sets default user agent

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47903





--- Comment #12 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2010-10-27 01:38:21 PST ---
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > (From update of attachment 71528 [details] [details] [details])
> > > View in context: https://bugs.webkit.org/attachment.cgi?id=71528&action=review
> > > 
> > > > cmakeconfig.h.cmake:9
> > > > +#define WEBKIT_USER_AGENT_MAJOR_VERSION (534)
> > > > +#define WEBKIT_USER_AGENT_MINOR_VERSION (7) 
> > > 
> > > Hmm, why not get these from webcore?
> > 
> > Are there funtions to know user agent version in WebCore? I don't find the functions yet.
> 
> I believe so, but you might have to "generate" them at build time. Take a look at what Qt does.

Sorry for my late reply. 

I don't find that QT port handles the version macro for user agent in WebCore yet.

I found a function to make user agent in QT port.

QString QWebPage::userAgentForUrl(const QUrl&) const 
{
...
3627         // webkit/qt version
3628         secondPartTemp += QString::fromLatin1("AppleWebKit/");
3629         secondPartTemp += qWebKitVersion();
3630         secondPartTemp += QString::fromLatin1(" (KHTML, like Gecko) ");
3631 
...
}

In WebKit/qt/Api,
QString qWebKitVersion()
{
    return QString("%1.%2").arg(WEBKIT_MAJOR_VERSION).arg(WEBKIT_MINOR_VERSION);
}

I couldn't find the definitions of "WEBKIT_MAJOR_VERSION" and "WEBKIT_MINOR_VERSION" macros except for configure.ac. Hmm, I am not sure if qt port uses configure.ac.

And,in WebKit/qt/qt_webkit_version.pri, Qt Port has some version macros as below,

  1 QT_WEBKIT_VERSION = 4.9.0
  2 QT_WEBKIT_MAJOR_VERSION = 4
  3 QT_WEBKIT_MINOR_VERSION = 9
  4 QT_WEBKIT_PATCH_VERSION = 0

I don't know if these macros are being used by user agent in qt port.

In my opinion, cmakeconfig.h file is not bad place to put the USER_AGENT macros.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.