[Webkit-unassigned] [Bug 48403] Typo fix in SVGFEConvolveMatrixElement-dom-* tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48403


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71995|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #7 from Dirk Schulze <krit at webkit.org>  2010-10-27 01:21:55 PST ---
(From update of attachment 71995)
View in context: https://bugs.webkit.org/attachment.cgi?id=71995&action=review

>>>> LayoutTests/ChangeLog:8
>>>> +        Since expecteds and pixel tests didn't change after correcting this attribute has no effect so it is removed.
>>> 
>>> Hm, what do you mean? Removing this attribute did not fix the currently failing tests, so we can remove it? :-P
>> 
>> These tests don't fail this time... I realized the preserveAlpha attribute is misspelled... I corrected it, but the expected didn't changed. It means the attribute doesn't have effect in this case, so we can remove it, right?
> 
> Ah, I saw that we have already preserverAlpha tests. Than I'm fine.
> 
> Niko and I noticed that we miss SVG DOM tests for feConvolveMatrix. Not sure if I missed it during the review process or someone else, but can you add SVG DOM tests in a new patch as well? After the changes of Niko to the SVG bindings, it shouldn't be a problem to test the kernelMatrix via SVG DOM.

Pleases write, that we already have a dom test for preserveAlpha which is not affected by this changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.