[Webkit-unassigned] [Bug 48032] [chromium] Added PluginLayerChromium for hardware accelerated compositing of plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48032





--- Comment #14 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-10-26 23:45:36 PST ---
(From update of attachment 71809)
View in context: https://bugs.webkit.org/attachment.cgi?id=71809&action=review

> WebKit/chromium/public/WebPlugin.h:70
> +    // FIXME: Make this pure virtual once this change is rolled into chromium.

note: methods implemented by the embedder do not need to be pure virtual.
it is actually encouraged to make them have default implementations to
simplify webkit rolls.

> WebKit/chromium/public/WebPluginContainer.h:60
> +    virtual unsigned getBackingTextureId() { return 0; };

why do you need this method here?  can't callers just get the WebPlugin
from the WebPluginContainer and call getBackingTextureId from there?

nit: no trailing ";"

> WebKit/chromium/public/WebPluginContainer.h:64
> +    virtual void commitBackingTexture() {};

nit: no trailing ";"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.