[Webkit-unassigned] [Bug 48220] constraint validation: stepMismatch (rounding error)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48220





--- Comment #7 from Dai Mikurube <dmikurube at google.com>  2010-10-26 21:46:27 PST ---
(From update of attachment 71863)
View in context: https://bugs.webkit.org/attachment.cgi?id=71863&action=review

>> WebCore/html/NumberInputType.cpp:122
>> +    double remainder = fabs(doubleValue - step * round(doubleValue / step));
> 
> Would you explain why we need to use fabs() instead of fmod() in a code comment or ChangeLog please?

Ok, added a detailed description in ChangeLog.

>> WebCore/html/NumberInputType.cpp:123
>> +    // Accepts errors in the equvalent precision to IEEE 754 single-precision
> 
> This comment is confusing.  "Accepts erros in lower fractional part which IEEE 754 single-precision can't represent." ?

Thank you. Replaced with your expression.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.