[Webkit-unassigned] [Bug 47624] Add AudioResamplerKernel files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47624





--- Comment #2 from Kenneth Russell <kbr at google.com>  2010-10-26 18:51:03 PST ---
(From update of attachment 70667)
View in context: https://bugs.webkit.org/attachment.cgi?id=70667&action=review

A few comments and questions.

> WebCore/platform/audio/AudioResamplerKernel.cpp:59
> +    int endIndex = static_cast<int>(nextFractionalIndex + 1.0); // round up to next integer index

Should this just use ceil()?

> WebCore/platform/audio/AudioResamplerKernel.cpp:102
> +        double sample2 = source[readIndex + 1];

It would be really nice to have some assertions (perhaps hoisted out of the loop) that m_virtualReadIndex + (framesToProcess * rate) + 1 is not going to walk off the end of the source buffer.

> WebCore/platform/audio/AudioResamplerKernel.h:57
> +protected:

Can these members be private rather than protected?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.