[Webkit-unassigned] [Bug 47517] Add DelayProcessor files

Tue Oct 26 18:41:07 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=47517

Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #70637|review?                     |review+
               Flag|                            |

--- Comment #5 from Kenneth Russell <kbr at google.com>  2010-10-26 18:41:07 PST ---
(From update of attachment 70637)
View in context: https://bugs.webkit.org/attachment.cgi?id=70637&action=review

Looks okay; r+'ing, but with one comment. Feel free to upload a revised patch.

> WebCore/webaudio/DelayProcessor.cpp:44
> +        uninitialize();

Looking at this afresh, this block of code looks like something that should be in the base class's destructor. Also, given that uninitialize() checks the isInitialized() flag it doesn't seem necessary to have the "if" test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.