[Webkit-unassigned] [Bug 39199] build-webkit should collect Visual Studio Express logs and display them

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39199





--- Comment #18 from Eric Seidel <eric at webkit.org>  2010-10-26 16:43:01 PST ---
(In reply to comment #17)
> (From update of attachment 69313 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=69313&action=review
> 
> r- to fix the issues in the Perl code.  Otherwise it looks good.
> 
> > WebKitTools/Scripts/build-webkit:479
> > +            system("$scriptDir/print-vse-failure-logs");
> 
> This needs to use File::Spec->catfile() now:
> 
>     system(File::Spec->catfile($scriptDir, "print-vse-failure-logs"));

Thanks!

> > WebKitTools/Scripts/print-vse-failure-logs:53
> > +            print filenames
> 
> Do you really want to print all of these out?

The whole idea with this script is to put something minimal in place that people who actually use windows can make better. :)

> > WebKitTools/Scripts/webkitdirs.pm:1193
> > +    return $willUseVCExpressWhenBuilding;
> 
> You need to call determineConfigurationForVisualStudio() first to guarantee that this variable is set properly:
> 
>     determineConfigurationForVisualStudio()
>     return $willUseVCExpressWhenBuilding;

Fixed.  Thanks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.