[Webkit-unassigned] [Bug 48342] Fix and cleanup of build systems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48342


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71907|review?                     |review-
               Flag|                            |




--- Comment #4 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-10-26 11:50:45 PST ---
(From update of attachment 71907)
View in context: https://bugs.webkit.org/attachment.cgi?id=71907&action=review

r- to fix the FeatureDefines.xcconfig files.  (Note that I only reviewed build-webkit and the Apple Xcode config files.)

> WebKit/mac/Configurations/FeatureDefines.xcconfig:-99
> -

Note that JavaScriptCore/Configurations/FeatureDefines.xcconfig should be exactly the same as WebCore/Configurations/FeatureDefines.xcconfig, WebKit/mac/Configurations/Configurations/FeatureDefines.xcconfig and WebKit2/Configurations/FeatureDefines.xcconfig.

It appears that ENABLE_FULLSCREEN_API is missing from all but JavaScriptCore's configuration file, and that WebKit2/Configurations/FeatureDefines.xcconfig is missing ENABLE_ACCELERATED_2D_CANVAS.

Thus I would copy JavaScriptCore/Configurations/FeatureDefines.xcconfig to replace all the other FeatureDefines.xcconfig files.

> WebKitTools/Scripts/build-webkit:-201
> -

The build-webkit script also appears to be missing ENABLE_FULLSCREEN_API support as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.