[Webkit-unassigned] [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48094





--- Comment #4 from Hin-Chung Lam <hclam at google.com>  2010-10-26 11:39:28 PST ---
(From update of attachment 71804)
View in context: https://bugs.webkit.org/attachment.cgi?id=71804&action=review

> WebKit/chromium/ChangeLog:5
> +        Fix globalAlpha support when using drawImage() to copy a video frame to a 2D canvas context.A

Remove stray A at the end.

> WebKit/chromium/ChangeLog:7
> +

After this empty line add some description about how this fix works.

> WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:400
> +        int alpha = round(256 * context->platformContext()->getAlpha());

shouldn't this be 255? If alpha is 1.0 then the value is 256.

> WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:-514
> -#endif  // ENABLE(VIDEO)

don't need to fix style in WebKit code.

> LayoutTests/media/video-canvas-alpha.html:30
> +   <video controls="true"></video>

Prefer pixel test without controls, since each time there's changes to controls you need to generate new images.

Also just <video controls> is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.