[Webkit-unassigned] [Bug 46535] WebKit does not build when PLUGIN_PROXY_FOR_VIDEO is enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46535


Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68804|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from Eric Carlson <eric.carlson at apple.com>  2010-10-26 11:06:41 PST ---
(From update of attachment 68804)
View in context: https://bugs.webkit.org/attachment.cgi?id=68804&action=review

> WebCore/html/HTMLMediaElement.cpp:3
> + * Copyright (C) Research In Motion Limited 2010. All rights reserved.

I don't know if we have guidelines about this, but my own policy is to only add a new copyright line when I make significant additions or changes to a file.


> WebCore/html/HTMLMediaElement.cpp:2182
> -    url = src();
> +    url = document()->completeURL(m_currentSrc);

This is not correct, m_currentSrc may not have been set at this point (it is set a few lines later in this function). Use "getNonEmptyURLAttribute(srcAttr)" instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.