[Webkit-unassigned] [Bug 48344] script-tests shouldn't require a wrapper script

Tue Oct 26 11:04:48 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=48344

--- Comment #3 from Darin Adler <darin at apple.com>  2010-10-26 11:04:47 PST ---
(In reply to comment #0)
> They'd be much more useful if they weren't so heavy-weight.
> 
> The most recent discussion on webkit-dev was that we should get rid of js-test-post.js (just do that onload) and have js-test-pre.js inject the CSS. Then JS tests would be something like:
> <!DocType html>
> <script  src="../../fast/js/resources/js-test-pre.js"></script>
> <!-- YOUR HTML HERE -->
> <script>
> // YOUR SCRIPT HERE
> </script>
> 
> No need for that wrapper script or the extra code.

Getting rid of js-test-post.js would be a nice simplification if we can do it.

I think you’re misunderstanding why we have the wrapper script, though. The original script-tests are JavaScript tests and many can run outside of WebKit entirely in a pure JavaScript mode. That’s why the script test is in a separate file, so that it can be run in a pure JavaScript testing environment.

Maciej created the wrapper so we could run these pure JavaScript tests without changing our run-webkit-tests script at all and also easily run them in the browser without using the test script.

If we get rid of the wrapper what we’ll lose is the ability to have pure JavaScript tests that run outside of WebKit. But we never did implement that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.