[Webkit-unassigned] [Bug 48225] Language attribute validation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48225





--- Comment #12 from Jeremy Orlow <jorlow at chromium.org>  2010-10-26 09:27:40 PST ---
(From update of attachment 71900)
View in context: https://bugs.webkit.org/attachment.cgi?id=71900&action=review

Does anyone else have any thoughts?

> LayoutTests/fast/dom/Element/language-valid.html:15
> +    <p id="description"></p>

I think description is still best on top

> WebCore/dom/Element.cpp:1509
> +        // Only A-Za-z0-9 and '-' are allowed in the language tag (see BCP 47)

period at end

> WebCore/dom/Element.cpp:1510
> +        size_t length = value.length();

not sure if there's any value to this being broken out.  Maybe just replace length with it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.