[Webkit-unassigned] [Bug 48225] Language attribute validation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48225





--- Comment #10 from Leandro Graciá Gil <leandrogracia at chromium.org>  2010-10-26 07:45:48 PST ---
(In reply to comment #6)
> (From update of attachment 71873 [details])
> > WebCore/dom/Element.cpp:1510
> > +        CString asciiOnly = value.string().ascii();
> 
> It seems as though we should be able to do this check without converting the whole string to ascii first.  Maybe this isn't a performance concern and thus keeping the code simple is best, but it seems as though you should be able to inspect the data directly.

There's another reason of doing this, and it's that ascii deals with the UTF16 encoding and converts all non-ascii characters to the question mark symbol. That way it avoids any nasty problems coming from the representation of non-ascii characters.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.