[Webkit-unassigned] [Bug 48225] Language attribute validation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48225


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71873|1                           |0
        is obsolete|                            |




--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-10-26 07:28:56 PST ---
(From update of attachment 71873)
View in context: https://bugs.webkit.org/attachment.cgi?id=71873&action=review

> LayoutTests/fast/dom/Element/language-valid.html:13
> +    <div id="console"></div>

put this under the <p>'s.  Otherwise it's kind of confusing to read the output.

> WebCore/ChangeLog:12
> +        https://bugs.webkit.org/show_bug.cgi?id=48225

move this under the first line (before the blank new line)

> WebCore/dom/Element.cpp:1508
> +    if (!value.isNull() && !value.isEmpty()) {

IsEmpty is a superset of isNull.  When in doubt, please look these things up so that code isn't more complex than it needs to be.

> WebCore/dom/Element.cpp:1510
> +        CString asciiOnly = value.string().ascii();

It seems as though we should be able to do this check without converting the whole string to ascii first.  Maybe this isn't a performance concern and thus keeping the code simple is best, but it seems as though you should be able to inspect the data directly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.