[Webkit-unassigned] [Bug 48220] constraint validation: stepMismatch (rounding error)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48220


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71863|review?                     |review-
               Flag|                            |




--- Comment #5 from Kent Tamura <tkent at chromium.org>  2010-10-26 07:01:29 PST ---
(From update of attachment 71863)
View in context: https://bugs.webkit.org/attachment.cgi?id=71863&action=review

> WebCore/html/NumberInputType.cpp:119
>      // is greater than step*2^DBL_MANT_DIG, the following fmod() makes no sense.

Needs to update the comment.  fmod() won't be used.

> WebCore/html/NumberInputType.cpp:122
> +    double remainder = fabs(doubleValue - step * round(doubleValue / step));

Would you explain why we need to use fabs() instead of fmod() in a code comment or ChangeLog please?

> WebCore/html/NumberInputType.cpp:123
> +    // Accepts errors in the equvalent precision to IEEE 754 single-precision

This comment is confusing.  "Accepts erros in lower fractional part which IEEE 754 single-precision can't represent." ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.