[Webkit-unassigned] [Bug 46868] Input Method inserts conversion candidates unexpectedly

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46868


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71859|review?                     |review+, commit-queue+
               Flag|                            |




--- Comment #15 from Kent Tamura <tkent at chromium.org>  2010-10-26 03:59:53 PST ---
(From update of attachment 71859)
View in context: https://bugs.webkit.org/attachment.cgi?id=71859&action=review

- The test doesn't pass with Chromium test_shell.  So we had better add the test to LayoutTest/platform/chromium/test_expectations.txt.

I still have some comments on the patch.  However, I think it's ok to commit this.

> LayoutTests/platform/chromium/fast/text/chromium-mac-duplicate-ime-composition.html:5
> +      var console = document.getElementById('console');

nit: We usually use 4-space indent for JavaScript code.

> WebKitTools/DumpRenderTree/chromium/TextInputController.cpp:254
> +    keyDown.windowsKeyCode = 0xE5; // VKEY_PROCESSKEY

We should add VKEY_PROCESSKEY to webkit/support/webkit_support.h of Chromium.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.