[Webkit-unassigned] [Bug 48202] [GTK] Port to new GtkScrollable interface in GTK+ 3.x

Tue Oct 26 01:24:09 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=48202

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71842|review?                     |review+
               Flag|                            |

--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2010-10-26 01:24:09 PST ---
(From update of attachment 71842)
View in context: https://bugs.webkit.org/attachment.cgi?id=71842&action=review

Okay. Patch looks great to me, but perhaps you might consider my suggestions before landing. Thanks!

> WebKit/gtk/webkit/webkitwebview.cpp:203
> +#ifndef GTK_API_VERSION_2
> +    , PROP_HADJUSTMENT
> +    , PROP_VADJUSTMENT
> +#endif

I guess I prefer the original method to this one. :/

> WebKit/gtk/webkit/webkitwebview.cpp:398
> +static void setHorizontalAdjustment(WebKitWebView* webView, GtkAdjustment* hadj)

My preference is to rename hadj/vadj to horizontalAdjustment/verticalAdjustment before landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.