[Webkit-unassigned] [Bug 48037] Triple click does not select whole line for mixed contenteditable regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48037





--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-25 19:41:06 PST ---
(From update of attachment 71730)
View in context: https://bugs.webkit.org/attachment.cgi?id=71730&action=review

On second thought, I'm not even sure if this bug is valid.  We normally disallow selections that cross editing boundaries.  Why should be allow selection be extended across editing boundaries?  This patch seems to introduce a serious inconsistency into the editing code.

> LayoutTests/platform/chromium-linux/editing/deleting/5390681-expected.txt:16
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> +  RenderBlock {HTML} at (0,0) size 800x600
> +    RenderBody {BODY} at (8,8) size 784x584
> +      RenderBlock {P} at (0,0) size 784x40
> +        RenderText {#text} at (0,0) size 768x39
> +          text run at (0,0) width 565: "This tests for a bug where expansion for smart delete would not consider editable boundaries. "
> +          text run at (565,0) width 177: "Only 'foo' should be deleted. "
> +          text run at (742,0) width 26: "You"
> +          text run at (0,20) width 101: "should see ' bar'."
> +      RenderBlock {DIV} at (0,56) size 784x20
> +        RenderInline {SPAN} at (0,0) size 20x19
> +          RenderText {#text} at (0,0) size 20x19
> +            text run at (0,0) width 20: "bar"
> +caret: position 0 of child 2 {DIV} of body

Wait, why are you adding this?

> LayoutTests/platform/chromium-linux/editing/deleting/delete-mixed-editable-content-001-expected.txt:27
> +EDITING DELEGATE: shouldBeginEditingInDOMRange:range from 0 of SPAN > SPAN > DIV > BODY > HTML > #document to 1 of SPAN > SPAN > DIV > BODY > HTML > #document
> +EDITING DELEGATE: webViewDidBeginEditing:WebViewDidBeginEditingNotification
> +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> +EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of SPAN > SPAN > DIV > BODY > HTML > #document to 0 of SPAN > SPAN > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > SPAN > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> +EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > SPAN > SPAN > DIV > BODY > HTML > #document to 5 of #text > SPAN > SPAN > DIV > BODY > HTML > #document
> +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> +EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of SPAN > SPAN > DIV > BODY > HTML > #document to 0 of SPAN > SPAN > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
> +EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
> +EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
> +layer at (0,0) size 800x600
> +  RenderView at (0,0) size 800x600
> +layer at (0,0) size 800x600
> +  RenderBlock {HTML} at (0,0) size 800x600
> +    RenderBody {BODY} at (8,8) size 784x584
> +      RenderBlock {DIV} at (0,0) size 204x24 [border: (2px solid #FF0000)]
> +        RenderInline {SPAN} at (0,0) size 40x19
> +          RenderText {#text} at (0,0) size 0x0
> +          RenderInline {SPAN} at (0,0) size 40x19
> +            RenderInline {SPAN} at (0,0) size 40x19
> +              RenderText {#text} at (2,2) size 40x19
> +                text run at (2,2) width 40: "12345"
> +          RenderText {#text} at (0,0) size 0x0
> +          RenderInline {SPAN} at (0,0) size 0x0
> +          RenderText {#text} at (0,0) size 0x0
> +        RenderText {#text} at (0,0) size 0x0
> +caret: position 0 of child 3 {SPAN} of child 1 {SPAN} of child 0 {DIV} of body

Same comment for this one.  Perhaps, you've forgot to remove these?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.