[Webkit-unassigned] [Bug 47848] [chromium] Check getGraphicsResetStatusARB and reinitialize the renderer in an error is returned.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47848


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71376|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #4 from Kenneth Russell <kbr at google.com>  2010-10-25 19:37:31 PST ---
(From update of attachment 71376)
View in context: https://bugs.webkit.org/attachment.cgi?id=71376&action=review

This looks good. Couple of tiny comments, not necessary to address (marking cq+).

> WebCore/ChangeLog:6
> +        renderer in an error is returned.

in -> if

> WebKit/chromium/ChangeLog:6
> +        renderer in an error is returned.

in -> if

> WebKit/chromium/src/WebViewImpl.cpp:2489
> +    RefPtr<LayerRendererChromium> layerRenderer = LayerRendererChromium::create(newContext);

Strictly speaking this should probably be newContext.release().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.