[Webkit-unassigned] [Bug 48272] REGRESSION(r70437): Git.revisions_changing_file no longer raises for non-existant files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48272





--- Comment #2 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-10-25 16:07:29 PST ---
(In reply to comment #1)
> % git log non_existant_file
> fatal: ambiguous argument 'non_existant_file': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions
> 
> % git log -- non_existant_file
> 
> however just churns for a long while and then outputs nothing and exits 0.  Both of those behaviors seem bad.  I wonder if there is some flag we should pass to git.

What is the code trying to do?  (Sorry, don't have time to peruse it now.)  Why don't you just test for the file's existence and skip running "git log" in that case?

I think "git log -- non_existant_file" may be checking the repository's history for any file that ever existed at that path.

I think some discussion about this under the "History Simplification" section in "man git-log".

This seems to run faster:  git log --since="1 day ago" -- foo

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.