[Webkit-unassigned] [Bug 48094] Setting globalAlpha on canvas and drawing a video does not honor alpha value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48094





--- Comment #2 from Aaron Colwell <acolwell at chromium.org>  2010-10-25 15:43:17 PST ---
(From update of attachment 71500)
View in context: https://bugs.webkit.org/attachment.cgi?id=71500&action=review

>> WebKit/chromium/ChangeLog:7
>> +
> 
> no mention of any test
> 
> perhaps we should write a new pixel layout test?

new patch has a layout test now.

>> WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:403
>> +        if (alpha > 255) {
> 
> webkit style:
>   - no braces on single line if statements
>   - indents are 4 spaces, not 2

fixed

>> WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:409
>> +        canvas->saveLayerAlpha(0, alpha);
> 
> so WebCanvas alpha is in 0-255, but the platform GraphicsContext is in float?!

yes. Essentially copied this code from another part of the codebase.

>> WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:415
>>          m_webMediaPlayer->paint(context->platformContext(), rect);
> 
> this code is for mac (CG = CoreGraphics) and I'm guessing we'll need to do something similar here

Verified that the issue doesn't exist on Mac. The context is passed down on Mac instead of the raw canvas.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.