[Webkit-unassigned] [Bug 17926] Unformat deletes images

Mon Oct 25 14:43:34 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=17926

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-25 14:43:33 PST ---
(In reply to comment #5)
> > LayoutTests/editing/execCommand/remove-format-image.html:2
> > +<html>
> 
> Don't need this tag. It just adds clutter. The doctype is useful because it forces standards mode though.

I don't think having <html> adds that much of cluttering.  I think most of tests that do have DOCTYPE also has html, and I'd rather conform to that trend.  Are you strongly inclined to remove this before landing?

> > LayoutTests/editing/execCommand/remove-format-image.html:3
> > +<body onload="runTests();">
> 
> Do you need to run this onload? Can't you just run the script inline? If you do that, you won't need the body tag in the test.

Yes.  Images aren't necessarily loaded by the time the script is ran, and we get a different result when that happens.  Or otherwise we'll make this test flaky.

> > LayoutTests/editing/execCommand/remove-format-image.html:5
> > +<div id="test1" contenteditable><storng>hello</strong> <img src="../resources/abe.png"> world</div>
> 
> typo:storng

Oops, thanks.  Will fix.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.