[Webkit-unassigned] [Bug 46794] Crashes randomly in cairo_scaled_font_destroy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 25 13:05:40 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46794


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71445|0                           |1
        is obsolete|                            |




--- Comment #15 from Martin Robinson <mrobinson at webkit.org>  2010-10-25 13:05:39 PST ---
Created an attachment (id=71786)
 --> (https://bugs.webkit.org/attachment.cgi?id=71786&action=review)
WIP patch taking Darin's advice into account

Darin, I've attached a patch for this issue which switches FontPlatformData.m_scaledFont to manual memory management and handles HashTableDeletedValue specifically. 

Some alternatives:
1. Create a RefCountedCairoPtr (similar to RefCountedGDIHandle on Windows), which essentially wraps the raw Cairo pointer in another layer of abstraction.
2. Handle -1 specifically in RefPtrCairo here: https://bugs.webkit.org/show_bug.cgi?id=48192

I hope my previous comment did not come off as too defensive. I appreciate your insight.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list