[Webkit-unassigned] [Bug 48169] [FileSystem] Support not creating directories when queried by inspector.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48169





--- Comment #2 from Kinuko Yasuda <kinuko at chromium.org>  2010-10-25 12:55:57 PST ---
(From update of attachment 71618)
View in context: https://bugs.webkit.org/attachment.cgi?id=71618&action=review

> WebKit/chromium/src/WebWorkerBase.cpp:240
> +void WebWorkerBase::openFileSystem(WebFileSystem::Type type, long long size, WebFileSystemCallbacks* callbacks, bool create, bool synchronous)

Per discussion, I don't think we need to propagate this flag via all the worker plumbing.

> WebKit/chromium/src/WebWorkerBase.h:96
> +    void openFileSystem(WebFileSystem::Type, long long size, WebFileSystemCallbacks*, bool create, bool synchronous);

ditto.

> WebKit/chromium/src/LocalFileSystemChromium.cpp:60
> +void LocalFileSystem::requestFileSystem(ScriptExecutionContext* context, AsyncFileSystem::Type type, long long size, PassOwnPtr<AsyncFileSystemCallbacks> callbacks, bool create, bool synchronous)

If the inspector version will not need the worker implementation, how about adding a new method like queryFileSystem that always calls openFileSystem with create=false and keeping this requestFileSystem as is.

> WebKit/chromium/src/LocalFileSystemChromium.cpp:66
> +        webFrame->client()->openFileSystem(webFrame, static_cast<WebFileSystem::Type>(type), size, create, new WebFileSystemCallbacksImpl(callbacks));

We still don't have the implementation in chromium -- let's put a default implementation in WebKit/public/WebFileSystem.h with FIXME comment:

  virtual void openFileSystem(WebKit::WebFrame* frame, WebKit::WebFileSystem::Type type, long long size, bool create, WebKit::WebFileSystemCallbacks* callbacks)
  {
       return openFileSystem(frame, type, size, true, callbacks);
  }

After we put chromium sides implementation we can remove the default implementation.

...and if we don't change the worker side code I think we can drop the change in WebCommonWorkerClient::openFileSystem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.