[Webkit-unassigned] [Bug 46794] Crashes randomly in cairo_scaled_font_destroy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46794





--- Comment #13 from Martin Robinson <mrobinson at webkit.org>  2010-10-25 11:54:18 PST ---
(In reply to comment #12)
> I think this is the wrong fix. The right way to do this is with hash traits, I think. This is not how RefPtr handles hash table deleted values. It's not a good idea to handle this differently for this RefPtr variant.

I did attempt the HashTraits approach at first, but this did not fix the issue (my first patch on this bug). I think the trouble is that the RefPtr isn't the type contained in the HashMap, it is the containing type FontPlatformData. This is handled as a one-off by the Windows port. See win/RefCountedGDIHandle.h. Perhaps in this case, it just makes sense to manage memory manually and deal with the -1 inside FontPlatformDataFreetype. I'll post a patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.