[Webkit-unassigned] [Bug 35422] [Gtk] Layout tables should indicate that they are not data tables via an object attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35422


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cfleizach at apple.com




--- Comment #5 from Mario Sanchez Prada <msanchez at igalia.com>  2010-10-25 11:17:51 PST ---
(In reply to comment #4)
> [...]
>   1. The code I'm changing doesn't really add new functionality other than splitting the 
>  behavior of the former isDataTable() function in two: isAccessibilityTable() and a more 
>  coherent version of the former isDataTable() function. It's more like a reorganization of the 
>  code to allow asking those two questions separately, where the new isAccessibilityTable() 
>  function is basically the same than the old isDataTable() in all the ports but the GTK one.
> 
>   2. Such differentiation is only used now in the GTK port (the patch makes sure the rest of 
>  the ports keep working exactly as usual), and that change is tested by the unit test provided 
>  along with this patch.
>  [...]

Even thouugh the changes in WebCore a11y code are really simple (I basically splitted a function in two, but the non-GTK ports keep working exactly as they did before) I think it might be a good idea to get this patch reviewed by someone from Apple. And when I join Apple + a11y code, Chris Fleizach cames to my mind :-). So adding him to CC. 

Feeling like reviewing this patch then, Chris? O:-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.