[Webkit-unassigned] [Bug 47365] getTextAtOffset returns incorrect results if a link includes text and an image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47365





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2010-10-25 11:17:18 PST ---
(From update of attachment 71412)
View in context: https://bugs.webkit.org/attachment.cgi?id=71412&action=review

Looks good, but I'm waiting for the reuslts of your experiments to give the final r+. We should switch to iterating the main main loop, if possible.

> WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:937
> +        GOwnPtr<gchar> rendererText(textForRenderer(accObject->renderer()));
> +        g_string_append(str, rendererText.get());

Thanks for fixing this. In the future it might make sense for these methods to just return CStrings. Perhaps a cleanup in some other patch.

> WebKit/gtk/tests/testatk.c:979
> +    g_idle_add((GSourceFunc)bail_out, loop);
> +    g_main_loop_run(loop);

I think we should also try to iterate the main main loop here as well. I think you're exploring that presently.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.