[Webkit-unassigned] [Bug 25539] spellcheck='' should be the same as spellcheck="true"

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25539


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71705|review?                     |review+
               Flag|                            |




--- Comment #9 from Tony Chang <tony at chromium.org>  2010-10-25 10:34:05 PST ---
(From update of attachment 71705)
The cr-linux compile error looks real.  There are 2 calls to spellCheckingEnabledInFocusedNode() in WebKit/chromium.  Fix those, and r=me.

> > WebCore/editing/Editor.cpp:2551
> > +    const Element* focusedElement = node->isElementNode() ? toElement(node) : node->parentElement();
> 
> Is it possible that node->parentElement() is null, but node->parent()->parentElement() is true?
I'm sorry but I could not get the point.
My intention here is to ensure that we check against Element class because node might be Text.
And Text might be orphaned.

The previous code looped over node->parent(), but the new code uses node->parentElement().  I was wondering if we were missing cases if parent() is not an element, but parent()->parentElement() is an element.  I don't think that's possible, so this seems fine.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.