[Webkit-unassigned] [Bug 40275] [BREWMP] Port graphics backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40275





--- Comment #16 from Kwang Yul Seo <kwangyul.seo at gmail.com>  2010-10-25 10:19:37 PST ---
(In reply to comment #15)
> (From update of attachment 71186 [details])
> It seems like these files only handle two cases - windows (in which case they use GDI) and everything else (originally just linux, but later freebsd and now brewmp).  Would it be useful to define another macro for the using-Skia-but-not-GDI case so we can stick the OS(LINUX) || OS(FREEBSD) || PLATFORM(BREWMP) logic all in one place?
> 
> Kwang, do you think such a macro would be useful in other files in addition to this pair?  If so we should consider adding it, but if it's just for these files then I think this way is fine.
> 
> R=me, request commit-queue again if you want to land with these macros.

Currently, only there files have OS(LINUX) || OS(FREEBSD) || PLATFORM(BREWMP) check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.