[Webkit-unassigned] [Bug 48068] Pass on all the speech recognition results to the input element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48068





--- Comment #4 from Satish Sampath <satish at chromium.org>  2010-10-25 10:02:09 PST ---
(In reply to comment #2)
> (From update of attachment 71440 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71440&action=review
> 
> > WebCore/page/SpeechInputResult.cpp:40
> > +    : m_confidence(0)
> 
> What uses this?

Apparently no one, removed.

> > WebCore/page/SpeechInputResult.h:48
> > +    SpeechInputResult();
> 
> What's this needed for?

Not needed, removed.

> > WebCore/platform/mock/SpeechInputClientMock.cpp:96
> > +        results.append(SpeechInputResult::create(m_recognitionResult, 1.0));
> 
> Would we ever see a 1.0 in the real world?  I guess it doesn't matter that much, though..

It would depend on the recognizer itself but 1.0 is a legal value per the proposed spec.

> > WebKit/chromium/public/WebSpeechInputListener.h:58
> > +    virtual void setRecognitionResult(int, const WebSpeechInputResultArray&) = 0;
> 
> None of these should be purely virtual.  Use WEBKIT_ASSERT_NOT_REACHED.

Done

> And, to avoid breaking the build, you should have the legacy version call the new version.

Done

> > WebKit/chromium/public/WebSpeechInputResult.h:46
> > +class WebSpeechInputResult {
> 
> This should just wrap the WebCore version and not actually store stuff itself.

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.