[Webkit-unassigned] [Bug 48068] Pass on all the speech recognition results to the input element.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48068


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71440|review?                     |review-
               Flag|                            |




--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-10-25 07:07:40 PST ---
(From update of attachment 71440)
View in context: https://bugs.webkit.org/attachment.cgi?id=71440&action=review

> WebCore/page/SpeechInputListener.h:37
> +

no newline

> WebCore/page/SpeechInputListener.h:60
> +    virtual void setRecognitionResult(int requestId, const SpeechInputResultArray& results) = 0;

results not needed

> WebCore/page/SpeechInputResult.cpp:37
> +

extra new line

> WebCore/page/SpeechInputResult.cpp:40
> +    : m_confidence(0)

What uses this?

> WebCore/page/SpeechInputResult.h:32
> +

no newline

> WebCore/page/SpeechInputResult.h:48
> +    SpeechInputResult();

What's this needed for?

> WebCore/platform/mock/SpeechInputClientMock.cpp:96
> +        results.append(SpeechInputResult::create(m_recognitionResult, 1.0));

Would we ever see a 1.0 in the real world?  I guess it doesn't matter that much, though..

> WebKit/chromium/public/WebSpeechInputListener.h:58
> +    virtual void setRecognitionResult(int, const WebSpeechInputResultArray&) = 0;

None of these should be purely virtual.  Use WEBKIT_ASSERT_NOT_REACHED.

And, to avoid breaking the build, you should have the legacy version call the new version.

> WebKit/chromium/public/WebSpeechInputResult.h:46
> +class WebSpeechInputResult {

This should just wrap the WebCore version and not actually store stuff itself.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.