[Webkit-unassigned] [Bug 48199] [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48199





--- Comment #6 from Antonio Gomes <tonikitoo at webkit.org>  2010-10-24 21:28:38 PST ---
(In reply to comment #5)
> >  Programs_DumpRenderTree_LDADD = \
> >      libwebkitgtk- at WEBKITGTK_API_MAJOR_VERSION@. at WEBKITGTK_API_MINOR_VERSION@.la \
> > +    WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DumpRenderTreeSupportGtk.o \
> 
> Is it not possible to simply list DumpRenderTreeSupportGtk.cpp in the same way that the other WebCoreSupport source files are listed?

Not sure if I understood your question well. To get built, both DumpRenderTreeSupportGtk.cpp|h are build together with other webcoresupport files, as seen below:

diff --git a/GNUmakefile.am b/GNUmakefile.am
--- a/GNUmakefile.am
+++ b/GNUmakefile.am
@@ -362,6 +362,8 @@ webkitgtk_sources += \
     WebKit/gtk/WebCoreSupport/EditorClientGtk.h \
     WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp \
     WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.h \
+    WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp \
+    WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.h \

However, GTK's DRT seems to just see Webkit/gtk/webkit symbols, so I had to manually add the .o , so the DRT links.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.