[Webkit-unassigned] [Bug 46122] Check endianness with __BIG_ENDIAN in RVCT.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 24 08:49:39 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=46122


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #68140|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #4 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-10-24 08:49:38 PST ---
(From update of attachment 68140)
View in context: https://bugs.webkit.org/attachment.cgi?id=68140&action=review

r- to update the test

> JavaScriptCore/wtf/Platform.h:213
> +#if defined(__ARMEB__) || defined(__BIG_ENDIAN) /* RVCT defines __BIG_ENDIAN */

Please use this instead since it's self-documenting:

    #if deined(__ARMEB__) || COMPILER(RVCT) && defined(__BIG_ENDIAN)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list