[Webkit-unassigned] [Bug 39199] build-webkit should collect Visual Studio Express logs and display them

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39199


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69313|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #17 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-10-24 08:10:08 PST ---
(From update of attachment 69313)
View in context: https://bugs.webkit.org/attachment.cgi?id=69313&action=review

r- to fix the issues in the Perl code.  Otherwise it looks good.

> WebKitTools/Scripts/build-webkit:479
> +            system("$scriptDir/print-vse-failure-logs");

This needs to use File::Spec->catfile() now:

    system(File::Spec->catfile($scriptDir, "print-vse-failure-logs"));

> WebKitTools/Scripts/print-vse-failure-logs:53
> +            print filenames

Do you really want to print all of these out?

> WebKitTools/Scripts/webkitdirs.pm:1193
> +    return $willUseVCExpressWhenBuilding;

You need to call determineConfigurationForVisualStudio() first to guarantee that this variable is set properly:

    determineConfigurationForVisualStudio()
    return $willUseVCExpressWhenBuilding;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.