[Webkit-unassigned] [Bug 37369] [GTK] Enable building whatever already exists of WebKit2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 22 22:49:02 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=37369
--- Comment #20 from WebKit Review Bot <webkit.review.bot at gmail.com> 2010-10-22 22:48:59 PST ---
Attachment 71620 did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
Last 3072 characters of output:
al.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/gtk/WebViewInternal.cpp:33: webkit_widget_view_realize is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/gtk/WebViewInternal.cpp:58: webkit_widget_view_container_add is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/gtk/WebViewInternal.cpp:85: webkit_widget_view_class_init is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/gtk/WebViewInternal.cpp:100: gobject_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/gtk/WebViewInternal.cpp:110: webkit_widget_view_init is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Shared/gtk/NativeWebKeyboardEventGtk.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Shared/gtk/WebEventFactory.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WARNING: File exempt from style guide. Skipping: "WebCore/platform/network/soup/cache/webkit/soup-cache.h"
WebKitTools/MiniBrowser/gtk/main.cpp:31: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/Launcher/gtk/ThreadLauncherGtk.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/UIProcess/gtk/WebContextGtk.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/MiniBrowser/gtk/BrowserWindow.cpp:31: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/gtk/MainGtk.cpp:27: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKit2/Platform/CoreIPC/gtk/ConnectionGtk.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 38 in 72 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list