[Webkit-unassigned] [Bug 23556] Right-to-left pages should be scrollable to reveal left overflow

Fri Oct 22 15:29:49 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=23556

Dave Hyatt <hyatt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66128|review?                     |review-
               Flag|                            |

--- Comment #49 from Dave Hyatt <hyatt at apple.com>  2010-10-22 15:29:47 PST ---
(From update of attachment 66128)
The scroll stuff looks fine.  I don't like the m_bodyIsLTR variable though.  If a different direction is explicitly specified on the root element, this should supercede the body's direction.  In addition, XML documents will typically set the direction on the root.

Since the time this patch has been worked on, I committed a fix that propagates both direction and writing-mode on the root element (<html>) up to the RenderView's style.  This means the RenderView itself now matches the direction and writing-mode of the <html>.  Rather than doing this m_bodyIsLTR hack, I think we should probably expand the propagation code I added to also propagate from the body.  It should only do this though if the <html> element didn't explicitly have its direction set.

You can see this code in CSSStyleSelector::styleForDocument and then it also dynamically updates the style in styleDidChange.

You may want to consider an initial checkin that just works with the RenderView's direction (using test cases that set RTL on <html>) and work on the propagation code from the <body> in a followup patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.