[Webkit-unassigned] [Bug 46335] Add EditingStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46335





--- Comment #10 from Eric Seidel <eric at webkit.org>  2010-10-22 14:21:15 PST ---
(From update of attachment 69542)
View in context: https://bugs.webkit.org/attachment.cgi?id=69542&action=review

Generally looks OK, but curiosu to teh answers to above.

> WebCore/editing/DeleteSelectionCommand.cpp:720
> +    document()->frame()->selection()->setTypingStyle(m_typingStyle ? m_typingStyle->style() : 0);

Any time we're reaching into the style like this I"m suspicious.
Since we're changing selection too, shouldn't we add a setTypingStyle method which takes an editing styel and deprecate the other one?

> WebCore/editing/SelectionController.h:243
> -    m_typingStyle.clear();
> +    m_typingStyle->clear();

Why not m_typingstyle = 0?

> WebCore/editing/SelectionController.h:248
> -    m_typingStyle = style;
> +    m_typingStyle->setStyle(style);

Seems odd to be reaching into the typeingstyle like this.  Will this go away?  Should this hav ea FIXME?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.