[Webkit-unassigned] [Bug 48060] Speed up op_jeq_null and op_jneq_null in JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48060





--- Comment #3 from Gabor Loki <loki at webkit.org>  2010-10-22 13:29:03 PST ---
> If we reorder these as:
>         enum { NullTag =         0xfffffffb };

It should be 0xffffffff (not 0xfffffffb)

>         enum { UndefinedTag =    0xfffffffe };
>         enum { Int32Tag =        0xfffffffd };
>         enum { CellTag =         0xfffffffc };
>         enum { TrueTag =         0xfffffffb };
>         enum { FalseTag =        0xfffffffa };
>         enum { EmptyValueTag =   0xfffffff9 };
>         enum { DeletedValueTag = 0xfffffff8 };

Anyway, it looks good to me, but we have to guard it with an ASSERT as well.
eg.: ASSERT(NullTag == 0xffffffff && UndefinedTag = 0xfffffffe);
or ASSERT(NullTag + 1 == 0 && UndefinedTag + 1 == NullTag);
Well, not a very nice one, but it is just an ASSERT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.