[Webkit-unassigned] [Bug 47089] Language tag in speech for HTML input elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47089


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71569|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #60 from Alexey Proskuryakov <ap at webkit.org>  2010-10-22 10:55:34 PST ---
(From update of attachment 71569)
View in context: https://bugs.webkit.org/attachment.cgi?id=71569&action=review

> WebCore/ChangeLog:18
> +        Fixed a problem in dom/Element.cpp that caused some layout tests to fail.

No need to mention that - this doesn't fix any problems in ToT.

> WebCore/ChangeLog:22
> +        (WebCore::Element::computeInheritedLanguage): includes a brief character
> +          validation for the BCP 47 language tag.

Please file a separate bug for this, and provide a patch that tests this change with default WebKit build options (i.e. outside of speech recognition context). r- for the need to split DOM changes out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.