[Webkit-unassigned] [Bug 48053] Make http locking default in NRWT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48053


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71535|review?                     |review+
               Flag|                            |




--- Comment #5 from Ojan Vafai <ojan at chromium.org>  2010-10-22 08:13:04 PST ---
(From update of attachment 71535)
Code looks fine. I think it would be clearer if there were just two methods: _start_servers_with_lock and _stop_servers_with_lock and those two methods contained all the logic. So, I would merge _stop_http_lock into _stop_servers_with_lock and the logic of lines 401-404 into _start_servers_with_lock. Then the if statement would look like this:

if self._current_group == "tests_to_http_lock":
    self._start_servers_with_lock()
elif self._have_http_lock:
    self._stop_servers_with_lock()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.