[Webkit-unassigned] [Bug 48120] SVGColor::cssText() shouldn't return #RRGGBBAA colors

Fri Oct 22 03:48:21 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=48120

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71545|review?                     |review-
               Flag|                            |

--- Comment #2 from Darin Adler <darin at apple.com>  2010-10-22 03:48:21 PST ---
(From update of attachment 71545)
View in context: https://bugs.webkit.org/attachment.cgi?id=71545&action=review

Fix looks good, but tests do not.

> LayoutTests/ChangeLog:9
> +        Color::serialized() is already exercised in depth by fast/canvas tests.

Sure, it’s good that function has good test coverage, but this patch doesn’t include a test case for the bug you are fixing!

These test results only show that we are switching from uppercase hex to lowercase hex.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.