[Webkit-unassigned] [Bug 48112] Make editing/deleting/5390681.html and editing/deleting/delete-mixed-editable-content-001.html dump text instead of render tree

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48112





--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org>  2010-10-21 23:44:21 PST ---
(From update of attachment 71529)
View in context: https://bugs.webkit.org/attachment.cgi?id=71529&action=review

Thanks for doing this!

> LayoutTests/editing/deleting/5390681-expected.txt:4
> +
> +
> +bar

This contains too little information.  I can't tell what kind of DOM we're generating.  When you're converting a test like this, you should be careful not to lose any information necessary to prevent regressions.  See the changeset that added this test (http://trac.webkit.org/changeset/24945/trunk/LayoutTests/editing/deleting/5390681.html in this case) and make sure the expected result encompasses necessary information to prevent any regression.  In this case particular, we want to avoid hitting an assert but we probably also want to know that we're not adding or removing inappropriate nodes.  So it's good to dump the DOM.  Including dump-as-markup.js and doing Markup.dump('div') will be a good way to achieve this.  http://trac.webkit.org/changeset/70031 is a good example of this kind of test conversion.

> LayoutTests/editing/deleting/delete-mixed-editable-content-001-expected.txt:2
> +12345 
> +

This contains too little information too.  We at least want to see the final DOM.  Please include dump-as-markup.js and dump the contents of the div.

> LayoutTests/editing/deleting/delete-mixed-editable-content-001.html:5
> -	selectAllCommand();
> -	deleteCommand();
> +    selectAllCommand();
> +    deleteCommand();

Great that you got rid of these tabs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.