[Webkit-unassigned] [Bug 48037] Triple click does not select whole line for mixed contenteditable regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48037





--- Comment #4 from kalman at chromium.org  2010-10-21 22:44:41 PST ---
(From update of attachment 71385)
View in context: https://bugs.webkit.org/attachment.cgi?id=71385&action=review

>> LayoutTests/ChangeLog:13
>> +        * editing/pasteboard/copy-backslash-with-euc-expected.txt:
> 
> Please explain what's happening in this test.

There is a bug in webkit where copy-pasting some text into the entire of a contenteditable span inserts an extra <br> character at the end.  Easy repro is
"foo <span contenteditable>bar</span> baz"
Double click on foo, ctrl+c, double click on bar, ctrl+v.
The bug was being triggered by the copy-backslash-with-euc test, and for some reason this patch fixes it.

>> LayoutTests/ChangeLog:25
>> +        * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
> 
> Please consider converting these two tests to dump-as-markup or dump-as-text tests first because I don't think these two tests need to test the rendering results.  We're more interested in the correctness of the resultant DOM, which can be verified more easily in dump-as-markup / dump-as-text format.  You can also reduce the size of this patch once the conversion is done.  Note you should file a separate bug if you're doing the conversion.

Sounds good.  Are you suggesting I do this in a different patch, submit it, then come back to this one?

>> WebCore/editing/visible_units.cpp:-801
>> -            break;
> 
> Could you elaborate on why it is okay to remove this check?  It's not too obvious to me that editable boundaries are respected without this check.

I'm not sure what you mean.  In what way should editable boundaries be respected?
Elaboration: it's this check that incorrectly stops the selection when a non-contenteditable region is encountered inside a contenteditable one.  I say "incorrectly" because both IE and FF select across them.  From what I can tell there is sanity checking elsewhere (VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.