[Webkit-unassigned] [Bug 46676] HTMLTreeBuilder's InForeignContent code needs a re-write

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=46676


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71523|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #10 from Adam Barth <abarth at webkit.org>  2010-10-21 22:04:09 PST ---
(From update of attachment 71523)
View in context: https://bugs.webkit.org/attachment.cgi?id=71523&action=review

Quite nice.  Thanks!

> WebCore/html/parser/HTMLTreeBuilder.cpp:2616
> +        setInsertionMode(InBodyMode);
>          processEndOfFile(token);

No prepareToReprocess here?

> WebCore/html/parser/HTMLTreeBuilder.cpp:2629
> +        prepareToReprocessToken();
>          processEndOfFile(token);

We could have added a reprocessEndOfFile call for symmetry, but I can see why you skipped it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.