[Webkit-unassigned] [Bug 40275] [BREWMP] Port graphics backend

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40275


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #71186|review?, commit-queue?      |review+
               Flag|                            |




--- Comment #15 from James Robinson <jamesr at chromium.org>  2010-10-21 20:20:41 PST ---
(From update of attachment 71186)
It seems like these files only handle two cases - windows (in which case they use GDI) and everything else (originally just linux, but later freebsd and now brewmp).  Would it be useful to define another macro for the using-Skia-but-not-GDI case so we can stick the OS(LINUX) || OS(FREEBSD) || PLATFORM(BREWMP) logic all in one place?

Kwang, do you think such a macro would be useful in other files in addition to this pair?  If so we should consider adding it, but if it's just for these files then I think this way is fine.

R=me, request commit-queue again if you want to land with these macros.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.